Skip to content

Adds custom avatar#1636

Open
tmkx wants to merge 1 commit intogitkraken:mainfrom
tmkx:feat/custom-avatar
Open

Adds custom avatar#1636
tmkx wants to merge 1 commit intogitkraken:mainfrom
tmkx:feat/custom-avatar

Conversation

@tmkx
Copy link
Copy Markdown

@tmkx tmkx commented Sep 13, 2021 •
edited
Loading

Description

Allow custom avatar url rule, backward compatible.

 "gitlens.remotes": [
   {
     "domain": "gitlab.intranet.com",
     "type": "Custom",
     "name": "Company",
     "protocol": "https",
     "urls": {
       "repository": "https://gitlab.intranet.com/${repo}",
       "branches": "https://gitlab.intranet.com/${repo}/branches",
       "branch": "https://gitlab.intranet.com/${repo}/commits/${branch}",
       "commit": "https://gitlab.intranet.com/${repo}/commit/${id}",
       "file": "https://gitlab.intranet.com/${repo}?path=${file}${line}",
       "fileInBranch": "https://gitlab.intranet.com/${repo}/blob/${branch}/${file}${line}",
       "fileInCommit": "https://gitlab.intranet.com/${repo}/blob/${id}/${file}${line}",
       "fileLine": "#L${line}",
       "fileRange": "#L${start}-L${end}",
+      "avatar": "https://avatar.intranet.com/employee?username=${name}&size=${size}"
     }
   }
 ]

close #302
close #1036

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@xiaoas
Copy link
Copy Markdown

xiaoas commented Dec 27, 2021

seems very promising. The MR will also give a more general solution to #281.

However the way custom avatar uri was provided was as a member of the Account class, bond to a commit. Might need further review from the repo maintainer.

@tmkx tmkx force-pushed the feat/custom-avatar branch from 08380c3 to 5c2e8ed Compare December 27, 2021 14:25
@tmkx tmkx force-pushed the feat/custom-avatar branch from 542078a to 77d3bd9 Compare April 28, 2022 11:14
@manc-lx
Copy link
Copy Markdown

manc-lx commented Aug 10, 2022

@tmkx , Why this PR is still pending? My organization is using azure devops, does this PR work on azure devops?

@tmkx
Copy link
Copy Markdown
Author

tmkx commented Aug 10, 2022

@tmkx , Why this PR is still pending? My organization is using azure devops, does this PR work on azure devops?

It's fully customizable, as well as can be used in azure.

@nunnsy
Copy link
Copy Markdown

nunnsy commented Oct 19, 2022

Is anyone still actively working on this?

@tmkx tmkx force-pushed the feat/custom-avatar branch from ea424f3 to c573c3e Compare November 5, 2022 08:43
@nunnsy
Copy link
Copy Markdown

nunnsy commented Nov 9, 2022

thanks @tmkx! @axosoft-ramint @eamodio just wondering if there's anything that needs to be done here before a review? cheers

@John-Dean
Copy link
Copy Markdown

John-Dean commented Jan 18, 2023

Is there any movement on this? I found issue #281 which is marked as closed but it seems to not function/there is no setting(?). I can't reply on the issue as it's marked as closed with no comments.

This PR seems like a fix for it and it's been sitting for a while.

Echoing what @nunnsy said; @tmkx is this ready for review?

@tmkx
Copy link
Copy Markdown
Author

tmkx commented Jan 19, 2023

@tmkx is this ready for review?

Yes

@baranwang
Copy link
Copy Markdown

baranwang commented Mar 21, 2023

When the PR will be merged into the main branch? @eamodio @d13

@tmkx tmkx force-pushed the feat/custom-avatar branch 2 times, most recently from f991b4f to fc3de11 Compare May 5, 2023 18:21
@latel
Copy link
Copy Markdown

latel commented Jul 12, 2023

When the PR will be merged into the main branch?

@tmkx tmkx force-pushed the feat/custom-avatar branch from fc3de11 to db8398a Compare October 18, 2023 12:18
@baranwang
Copy link
Copy Markdown

baranwang commented Oct 19, 2023

ping @eamodio @d13 @axosoft-ramint

@tmkx tmkx force-pushed the feat/custom-avatar branch from db8398a to a98b182 Compare December 11, 2023 16:58
@cjlawson02
Copy link
Copy Markdown

cjlawson02 commented Oct 15, 2024

Any update on this?

@BillScott1024
Copy link
Copy Markdown

BillScott1024 commented Nov 4, 2024

Is there anyone to resolve the conficts ? 🤔

@tmkx tmkx force-pushed the feat/custom-avatar branch from a98b182 to 60cbcd7 Compare November 4, 2024 09:21
@jsun969 jsun969 mentioned this pull request Aug 13, 2025
Open
@tmkx tmkx force-pushed the feat/custom-avatar branch from 60cbcd7 to ca79829 Compare October 20, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get avatar from user Get GitLab avatar by email

10 participants

@tmkx @xiaoas @manc-lx @nunnsy @John-Dean @baranwang @latel @cjlawson02 @BillScott1024 @eamodio